Micron Document
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
| SparkN0de-git | SparkN0de |
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Node / ReticulumProjects / RNode_Firmware.git / commits / 30a07a3


Commit 30a07a32cecd324c03c04896a63b560cb29d93ca

󰉖 Browse tree at this commit

Parents : 1275c58
Author : Matt Corallo <649246+TheBlueMatt@users.noreply.github.com>
Signature : Signature validation error
Date : 2019-09-26T22:22:05Z
Committer : GitHub <noreply@github.com>
Date : 2019-09-26T22:22:05Z

Fix RSSI offset for pre-msg RSSI notification

last_rssi is a large negative number, with rssi_offset being +292,
intended to be added to put the value inside the range of a single byte uint.
Before sending the data message, a RSSI message is automatically sent,
which is quite nice, but the value ends up overflowing the 8-bit uint, giving
a bogus value.

Changes

1 files changed, 2 insertions(+), 2 deletions(-)

M RNode_Firmware.ino +2 -2

Diff

diff --git a/RNode_Firmware.ino b/RNode_Firmware.ino
index 4928529..6bf3bfb 100644
--- a/RNode_Firmware.ino
+++ b/RNode_Firmware.ino
@@ -144,7 +144,7 @@ void receiveCallback(int packet_size) {
// recieved packet to the host.
Serial.write(FEND);
Serial.write(CMD_STAT_RSSI);
- Serial.write((uint8_t)(last_rssi-rssi_offset));
+ Serial.write((uint8_t)(last_rssi+rssi_offset));
Serial.write(FEND);
// And then write the entire packet
@@ -170,7 +170,7 @@ void receiveCallback(int packet_size) {
// recieved packet to the host.
Serial.write(FEND);
Serial.write(CMD_STAT_RSSI);
- Serial.write((uint8_t)(last_rssi-rssi_offset));
+ Serial.write((uint8_t)(last_rssi+rssi_offset));
Serial.write(FEND);
// And then write the entire packet


──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────